send STREAT-START event to downstream when app pushes data after sending EOS - #1719
Closed
kkanag314 wants to merge 1 commit into
Closed
send STREAT-START event to downstream when app pushes data after sending EOS#1719kkanag314 wants to merge 1 commit into
kkanag314 wants to merge 1 commit into
Conversation
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Procedure:
Root Cause:
During MediaSource reuse across ad/content transitions, the pipeline remained in EOS state after EOS was pushed. Since STREAM_START was not re-sent, subsequent CAPS and buffer pushes failed, causing the MediaSource to close and resulting in a green screen during stream transitions.
Fix Done:
Modified webKitMediaSrcLoop() to reset wasStreamStartSent on EOS and re-send STREAM_START when the MediaSource is reused. This allows the pipeline to recover from EOS state and correctly process new segments during period and ad transitions.